[
https://issues.apache.org/jira/browse/GEODE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270532#comment-17270532
]
ASF GitHub Bot commented on GEODE-8845:
---------------------------------------
codecov-io edited a comment on pull request #724:
URL: https://github.com/apache/geode-native/pull/724#issuecomment-762443413
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=h1)
Report
> Merging
[#724](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=desc)
(e40034c) into
[develop](https://codecov.io/gh/apache/geode-native/commit/c1886061ff94e328d4675206b34c3a4868510600?el=desc)
(c188606) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #724 +/- ##
===========================================
- Coverage 74.08% 74.02% -0.07%
===========================================
Files 645 645
Lines 50858 50858
===========================================
- Hits 37680 37646 -34
- Misses 13178 13212 +34
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw)
| `81.25% <0.00%> (-18.75%)` | :arrow_down: |
|
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
| `54.36% <0.00%> (-2.82%)` | :arrow_down: |
|
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
| `71.11% <0.00%> (-1.67%)` | :arrow_down: |
|
[cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==)
| `65.16% <0.00%> (-0.57%)` | :arrow_down: |
|
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
| `76.31% <0.00%> (-0.43%)` | :arrow_down: |
|
[cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==)
| `76.59% <0.00%> (+1.06%)` | :arrow_up: |
|
[...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw)
| `89.51% <0.00%> (+4.03%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=footer).
Last update
[c188606...e40034c](https://codecov.io/gh/apache/geode-native/pull/724?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Missing public Declarations for .NET Cacheables
> ---------------------------------------------------
>
> Key: GEODE-8845
> URL: https://issues.apache.org/jira/browse/GEODE-8845
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Minor
> Labels: pull-request-available
>
> The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard
> .NET types. However, several of them are missing the public declarations,
> making them inaccessible.
> These classes provide a hashCode() function that matches the corresponding
> hashCode on the server side. It would be nice to be able to leverage these
> functions when using these types in a key class. I discovered this when
> implementing a new ClassAsKey example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
