[
https://issues.apache.org/jira/browse/GEODE-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271408#comment-17271408
]
ASF GitHub Bot commented on GEODE-8698:
---------------------------------------
pdxcodemonkey commented on pull request #699:
URL: https://github.com/apache/geode-native/pull/699#issuecomment-766926662
@gaussianrecurrence What's the status on this one? It's been pending with
changes requested for a little over a month...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove TcrPoolEndPoint::registerDM unnecessary DM lock
> ------------------------------------------------------
>
> Key: GEODE-8698
> URL: https://issues.apache.org/jira/browse/GEODE-8698
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.12.0, 1.13.0
> Reporter: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> Within TcrPoolEndPoint::registerDM, there is a lock for the DM connection
> queue mutex,
> which is not really necessary given that, as stated before, having a hard
> restriction on the connection number is not a must.
> Problem with this lock is that if any of the pool endpoints fails,
> connections are on hold while this endpoint is restored.
> One of the examples I've seen is that whenever a server goes down, and a pool
> with subscription enabled tries to re-open the subscription connection, all
> of the threads get locked due to this, even if they are not connecting to the
> server which is failing.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
