[
https://issues.apache.org/jira/browse/GEODE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272236#comment-17272236
]
ASF GitHub Bot commented on GEODE-8857:
---------------------------------------
sabbey37 commented on a change in pull request #5949:
URL: https://github.com/apache/geode/pull/5949#discussion_r564667114
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -181,6 +181,7 @@
***************************************/
// do not call these directly, only to be used in other commands
INTERNALPTTL(null, INTERNAL, new ExactParameterRequirements(2)),
+ INTERNALTYPE(null, INTERNAL, new ExactParameterRequirements(2)),
INTERNALSMEMBERS(null, INTERNAL, new ExactParameterRequirements(3)),
Review comment:
Is it weird that a user would be able to call these from the CLI and
would get different error messages if they did (like "wrong number of
arguments" instead of "unknown command" error? Not sure why they would and
maybe it doesn't really matter. I guess I'm just wondering if there's a way of
preventing that or some other way of doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis SMOVE command should not do type checking in the executor
> ---------------------------------------------------------------
>
> Key: GEODE-8857
> URL: https://issues.apache.org/jira/browse/GEODE-8857
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Since there is a type check in the executor, it results in stats
> (hits/misses) being updated which is not desirable.
> Since there are already set-type checks in place for when a set is retrieved
> this check should not be necessary.
> Add a test case for this to {{AbstractSMoveIntegrationTest}} and remove any
> relevant {{@Ignores}} in {{AbstractHistsMissesIntegrationTest}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
