[
https://issues.apache.org/jira/browse/GEODE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272301#comment-17272301
]
ASF GitHub Bot commented on GEODE-8811:
---------------------------------------
jchen21 commented on a change in pull request #5953:
URL: https://github.com/apache/geode/pull/5953#discussion_r564722069
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientRegistrationEventQueueManager.java
##########
@@ -37,15 +39,25 @@
*/
public class ClientRegistrationEventQueueManager {
private static final Logger logger = LogService.getLogger();
+
private final Set<ClientRegistrationEventQueue> registeringProxyEventQueues =
ConcurrentHashMap.newKeySet();
void add(final InternalCacheEvent event,
+ final ClientUpdateMessageImpl clientMessage,
final Conflatable conflatable,
final Set<ClientProxyMembershipID> originalFilterClientIDs,
final CacheClientNotifier cacheClientNotifier) {
- if (registeringProxyEventQueues.isEmpty())
+ if (registeringProxyEventQueues.isEmpty()) {
return;
+ }
+
+ if (originalFilterClientIDs.isEmpty()) {
Review comment:
How about combine all the conditions into a single `if` statement,
instead of two?
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/InternalRegion.java
##########
@@ -449,6 +450,8 @@ default void unlockWhenRegionIsInitializing() {
CachePerfStats getRegionPerfStats();
+ void handleInterestEvent(InterestRegistrationEvent event);
Review comment:
Do you want to make it `public`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create events are fired as update events
> ----------------------------------------
>
> Key: GEODE-8811
> URL: https://issues.apache.org/jira/browse/GEODE-8811
> Project: Geode
> Issue Type: Bug
> Components: cq
> Reporter: Nabarun Nag
> Assignee: Kirk Lund
> Priority: Major
> Labels: GeodeOperationAPI, blocks-1.14.0, pull-request-available
>
> When the failing client fires the event for an object during register
> interest ... it shows the expected value as the "oldValue" (vs. the newValue)
> ... and newValue == null and the OperationType as UPDATE (vs. CREATE).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
