[ 
https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276408#comment-17276408
 ] 

ASF GitHub Bot commented on GEODE-8543:
---------------------------------------

pivotal-jbarrett commented on a change in pull request #705:
URL: https://github.com/apache/geode-native/pull/705#discussion_r567922837



##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -161,7 +163,7 @@ Server::Server(Cluster &cluster, std::vector<Locator> 
&locators,
     hostname = "ip6-localhost";
   }
 
-  auto port = static_cast<uint16_t>(0);
+  auto port = Framework::getAvailablePort();

Review comment:
       Geode server will select its own ephemeral port if we send 0. We should 
preserve this default behavior in the tests. If you test needs to know the 
specific port of the server then that test should use this method to get a free 
port and assign it to the server in the cluster config. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Client disconnects from server due to exception on other server
> ---------------------------------------------------------------
>
>                 Key: GEODE-8543
>                 URL: https://issues.apache.org/jira/browse/GEODE-8543
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Jakov Varenina
>            Priority: Major
>              Labels: pull-request-available
>
> In ThinClientBaseDM::handleEPError when the client receives an exception from 
> a given endpoint, it will mark that server dead if in the exception contains 
> "java.lang.OutOfMemoryError",
> "org.apache.geode.distributed.ShutdownException" or 
> "org.apache.geode.cache.CacheClosedException" ( in 
> ThinClientBaseDM::unrecoverableServerError() )
> The problem is that the server causing the exception can be a different 
> server than the endpoint the client is connected to. In that case,
> the client will wrongly close a connection to a working server.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to