[
https://issues.apache.org/jira/browse/GEODE-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279963#comment-17279963
]
ASF subversion and git services commented on GEODE-8921:
--------------------------------------------------------
Commit 3c40a5dbd41e4ab2397b506432faac2f26713c82 in geode-native's branch
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=3c40a5d ]
GEODE-8921: Enable "extra qualification" warning in Windows builds (#741)
- This would bite developers from time to time, because code with extra
qualifications will build on Windows, but all other platforms will
flag it with a warning and break the build.
- Disable warning in a couple of test files. One of the boost log headers
triggers warning C4596
- Fix tabs. Indentation was messed up in a couple of places
> Enable "extra qualifications" warning on Windows builds
> -------------------------------------------------------
>
> Key: GEODE-8921
> URL: https://issues.apache.org/jira/browse/GEODE-8921
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Assignee: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a developer, I would like to be assured as much as possible that, if my
> code builds on the platform I'm running on my dev machine, it will build for
> all of our supported platforms. One very notable exception to this has been
> the "extra qualifications" warning, which is not enabled by default in Visual
> Studio. Thus, the following code will build in our environment on Windows,
> but _only_ on Windows:
> {code:java}
> class Foo
> {
> public:
> void Foo::bar();
> }; {code}
> This is warning C4596 in the Microsoft tools, and we need to explicitly
> enable it in our builds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
