[jira] [Created] (GEODE-8973) Error handling might cause calls to be duplicated

[Mario Salazar de Torres (Jira)]

Mario Salazar de Torres created GEODE-8973:
----------------------------------------------

             Summary: Error handling might cause calls to be duplicated
                 Key: GEODE-8973
                 URL: https://issues.apache.org/jira/browse/GEODE-8973
             Project: Geode
          Issue Type: Bug
          Components: native client
    Affects Versions: 1.14.0
            Reporter: Mario Salazar de Torres


**When using throwExceptionIfError macro if any of its parameter is a call
 then such call could be duplicated and in the case of the error there are 
cases within ThinClientPoolDM that could lead to requests duplications and 
inconsistencies.
----
One from *ThinClientPoolDM::AddPdxType* example is 
{code:java}
throwExceptionIfError("Operation Failed", sendSyncRequest(request, 
reply));{code}
This is one of the reasons why using macros are dis-recommended by C++ standard 
comittee and they should eventually be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)