[
https://issues.apache.org/jira/browse/GEODE-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294713#comment-17294713
]
ASF GitHub Bot commented on GEODE-8979:
---------------------------------------
echobravopapa commented on a change in pull request #6079:
URL: https://github.com/apache/geode/pull/6079#discussion_r586663171
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/internal/net/SSLSocketHostNameVerificationIntegrationTest.java
##########
@@ -211,18 +211,17 @@ private Thread startServerNIO(final ServerSocket
serverSocket, int timeoutMillis
} catch (Throwable throwable) {
serverException = throwable;
} finally {
- if (engine != null && socket != null) {
+ if (engine != null) {
Review comment:
what a helpful tool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure: SSLSocketHostNameVerificationIntegrationTest
> --------------------------------------------------------
>
> Key: GEODE-8979
> URL: https://issues.apache.org/jira/browse/GEODE-8979
> Project: Geode
> Issue Type: Test
> Components: membership, messaging
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Labels: pull-request-available
>
> This test failed in a CI IntegrationTest run with this exception:
> {noformat}
> org.apache.geode.internal.net.SSLSocketHostNameVerificationIntegrationTest >
> nioHandshakeValidatesHostName[hasSAN=true and doEndPointIdentification=true]
> FAILED
> org.apache.geode.GemFireIOException: exception closing SSL session
> at
> org.apache.geode.internal.net.NioSslEngine.close(NioSslEngine.java:409)
> at
> org.apache.geode.internal.net.SSLSocketHostNameVerificationIntegrationTest.lambda$startServerNIO$3(SSLSocketHostNameVerificationIntegrationTest.java:216)
> Caused by:
> java.io.IOException: Connection reset by peer
> at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
> at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
> at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
> at sun.nio.ch.IOUtil.write(IOUtil.java:51)
> at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:470)
> at
> org.apache.geode.internal.net.NioSslEngine.close(NioSslEngine.java:403)
> ... 1 more
> {noformat}
> It looks like the test needs to have a try/catch for IOException when closing
> the NioSslEngine.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
