[
https://issues.apache.org/jira/browse/GEODE-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298142#comment-17298142
]
ASF subversion and git services commented on GEODE-8972:
--------------------------------------------------------
Commit c2fc107bad1de221157072470e2a6ad426533f20 in geode's branch
refs/heads/develop from Kamilla Aslami
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c2fc107 ]
GEODE-8972: remove shunnedMembers collection from GMSMembership (#6089)
* GEODE-8972: remove shunnedMembers collection from GMSMembership
* Changes after the code review
> remove shunnedMembers collection from GMSMembership
> ---------------------------------------------------
>
> Key: GEODE-8972
> URL: https://issues.apache.org/jira/browse/GEODE-8972
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bruce J Schuchardt
> Assignee: Kamilla Aslami
> Priority: Major
> Labels: pull-request-available
>
> GMSMembership has a _shunnedMembers_ collection that is used to track the IDs
> of nodes that are no longer part of the cluster. This collection is no
> longer needed since we can tell if a node is old by comparing the view ID in
> its identifier to that of the current view (called _latestView_ in that
> class. Checks like this are already in place in some parts of the code.
> All uses of _shunnedMembers_ should be replaced with this check.
> MembershipView<ID> view = latestView;
> boolean shunned = memberId.getVmViewId() <= view.getViewId() &&
> !view.contains(memberId);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
