[
https://issues.apache.org/jira/browse/GEODE-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312495#comment-17312495
]
ASF GitHub Bot commented on GEODE-8968:
---------------------------------------
pdxcodemonkey commented on a change in pull request #770:
URL: https://github.com/apache/geode-native/pull/770#discussion_r602567152
##########
File path: cppcache/integration/test/PdxInstanceTest.cpp
##########
@@ -31,32 +27,53 @@
#include <geode/PoolManager.hpp>
#include <geode/RegionFactory.hpp>
#include <geode/RegionShortcut.hpp>
-#include <geode/TypeRegistry.hpp>
#include "LocalRegion.hpp"
#include "NestedPdxObject.hpp"
#include "PdxType.hpp"
+#include "mock/CacheListenerMock.hpp"
namespace {
using apache::geode::client::Cache;
using apache::geode::client::CacheableKey;
using apache::geode::client::CacheableString;
+using apache::geode::client::CacheFactory;
+using apache::geode::client::CacheListenerMock;
+using apache::geode::client::CacheRegionHelper;
using apache::geode::client::IllegalStateException;
using apache::geode::client::LocalRegion;
+using apache::geode::client::PdxInstance;
using apache::geode::client::PdxInstanceFactory;
using apache::geode::client::PdxSerializable;
+using apache::geode::client::PoolFactory;
using apache::geode::client::Region;
using apache::geode::client::RegionShortcut;
+using apache::geode::client::SelectResults;
using PdxTests::Address;
using PdxTests::PdxType;
using testobject::ChildPdx;
using testobject::ParentPdx;
+using testing::_;
+using testing::DoAll;
+using testing::InvokeWithoutArgs;
+using testing::Return;
+
const std::string gemfireJsonClassName = "__GEMFIRE_JSON";
+Cache createTestCache() {
+ auto cache = CacheFactory()
+ .set("log-level", "debug")
Review comment:
please set log-level to "none" for integration tests. It makes a big
difference in performance of CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> PdxTypeRegistry clean up causes a coredump
> ------------------------------------------
>
> Key: GEODE-8968
> URL: https://issues.apache.org/jira/browse/GEODE-8968
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.14.0
> Reporter: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> *GIVEN* a client/server that with PDX serialization
> *WHEN* the client looses connection towards the cluster
> *AND* PdxTypeRegistry is cleaned up
> *WHILE* a PDX instance is being serialized
> *THEN* a coredump occurs
> ----
> *Additional information:*
> As it seems PdxHelper::serializePdx calls toData -> toDataMutable ->
> getPdxType and the later part returns a nullptr if the registry was cleaned
> up in the process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
