[
https://issues.apache.org/jira/browse/GEODE-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326938#comment-17326938
]
ASF GitHub Bot commented on GEODE-9171:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #786:
URL: https://github.com/apache/geode-native/pull/786#discussion_r617883589
##########
File path: clicache/src/Cache.cpp
##########
@@ -57,6 +56,22 @@ namespace Apache
m_typeRegistry = gcnew Apache::Geode::Client::TypeRegistry(this);
}
+ Cache::~Cache() {
+ if (m_nativeptr) {
+ try {
+ if (!IsClosed) {
+ Close();
+ }
+ }
+ catch (...) {
+ }
+ finally{
Review comment:
formatting is all out of wack.
##########
File path: cppcache/src/ThreadPool.cpp
##########
@@ -14,7 +14,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
#include "ThreadPool.hpp"
Review comment:
Another random format change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads Aren't Being Terminated
> -------------------------------
>
> Key: GEODE-9171
> URL: https://issues.apache.org/jira/browse/GEODE-9171
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> For .NET applications using the native client, threads aren't being
> terminated when the native client Cache is closed. This causes a huge leak of
> memory which can cause long running apps to crash.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
