[
https://issues.apache.org/jira/browse/GEODE-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332666#comment-17332666
]
ASF subversion and git services commented on GEODE-9176:
--------------------------------------------------------
Commit 569cf39ea6357e87b66999fcffe0fca146d1d7a0 in geode-benchmarks's branch
refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=569cf39 ]
GEODE-9176: Automatically pass properties to benchmark JVMs (#149)
Converting all of the system properties we use in the benchmarks to start with
the benchmark
prefix. Changing the gradle build to copy all benchmark.* properties as system
properties in the tst.
Getting rid of problematic org.json dependency, and also making
sure we capture *all* system properties that might effect the behavior of the
test.
Adding a way to automatically set system properties in test JVMs. Just add a
property
with the prefix benchmark.system.ROLE, where ROLE is the role of jvms to
target. Eg
benchmark.system.server.gemfire.disablePartitionedRegionBucketAck=true would set
gemfire.disablePartitionedRegionBucketAck=true in the server JVMs.
Logging all benchmark properties during test run
> Automatically pass benchmark properties to benchmark JVMs
> ---------------------------------------------------------
>
> Key: GEODE-9176
> URL: https://issues.apache.org/jira/browse/GEODE-9176
> Project: Geode
> Issue Type: Improvement
> Components: benchmarks
> Reporter: Dan Smith
> Assignee: Dan Smith
> Priority: Major
> Labels: pull-request-available
>
> The geode-benchmarks currently have some hard coded system properties that
> can be used to change the behavior of the tests. Each property is copied by
> hand the build.gradle file.
> We should not need to name each property in build.gradle file if the
> properties use a consistent naming convention. In addition, we can dump out
> all of the properties that were set with a benchmark to keep track of what
> was different in that run.
> Finally, it's often helpful when debugging to automatically set system
> properties on test JVMs, for example to change geode behavior. By using a
> naming convention we can also automatically pass properties to the benchmark
> JVMs.
> To accomplish this, all existing properties will be renamed to start with
> "benchmark." These properties can be passed as gradle flags. For example
> {code}
> ./gradlew benchmark -Pbenchmark.withThreads=10)
> {code}
> Properties that start with "benchmark.system.ROLE." will be set as system
> properties in the test JVMs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
