[
https://issues.apache.org/jira/browse/GEODE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343550#comment-17343550
]
ASF GitHub Bot commented on GEODE-9249:
---------------------------------------
mmartell commented on a change in pull request #804:
URL: https://github.com/apache/geode-native/pull/804#discussion_r631366781
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -1066,8 +1066,8 @@ GfErrType ThinClientRegion::removeNoThrow_remote(
// do TCR remove
TcrMessageDestroy request(new DataOutput(m_cacheImpl->createDataOutput()),
- this, keyPtr, cvalue, aCallbackArgument,
- m_tcrdm.get());
+ this, keyPtr, cvalue, cvalue == nullptr,
Review comment:
Since the region->remove() and region->destroy() APIs all use
TcrMessageDestroy, there's actually two types of Destroy messages that can be
sent to the server. This parameter is needed to send the proper one based on
whether the user is removing a key or a key and a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove(key, nullptr) Not Working Properly
> -----------------------------------------
>
> Key: GEODE-9249
> URL: https://issues.apache.org/jira/browse/GEODE-9249
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The Region API supports both local and remote operations. Local operations
> apply to CACHING_PROXY regions and are supposed to affect only the local
> cache. However, localInvalidate(key, value) invalidates both local and remote
> entry.
>
> This is actually a but in remove(key, nullptr), not localInvalidate.
>
> Note: Invalidate operations sets the value for the given key to null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
