[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353496#comment-17353496
]
ASF GitHub Bot commented on GEODE-9110:
---------------------------------------
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641729834
##########
File path: cppcache/integration/framework/Cluster.h
##########
@@ -127,6 +127,8 @@ using ConserveSockets = NamedType<bool, struct
useConserveSocketsParameter>;
class Cluster {
public:
+ enum class Subscription_State { Enabled, Disabled };
Review comment:
Thy will be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> ------------------------------------------------------------------
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
