[
https://issues.apache.org/jira/browse/GEODE-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358702#comment-17358702
]
ASF subversion and git services commented on GEODE-8698:
--------------------------------------------------------
Commit ab6fe7d996e5ec23832f90663d03f1d66b9f5fbd in geode-native's branch
refs/heads/develop from Mario Salazar de Torres
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=ab6fe7d ]
GEODE-8698:Remove TcrPoolEndpoint::registerDM lock (#699)
- Removed pool lock when registering a new DM.
- This solves the thread inter-lock whenever putting back connections.
> Remove TcrPoolEndPoint::registerDM unnecessary DM lock
> ------------------------------------------------------
>
> Key: GEODE-8698
> URL: https://issues.apache.org/jira/browse/GEODE-8698
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.12.0, 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> Within TcrPoolEndPoint::registerDM, there is a lock for the DM connection
> queue mutex,
> which is not really necessary given that, as stated before, having a hard
> restriction on the connection number is not a must.
> Problem with this lock is that if any of the pool endpoints fails,
> connections are on hold while this endpoint is restored.
> One of the examples I've seen is that whenever a server goes down, and a pool
> with subscription enabled tries to re-open the subscription connection, all
> of the threads get locked due to this, even if they are not connecting to the
> server which is failing.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)