[ 
https://issues.apache.org/jira/browse/GEODE-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369660#comment-17369660
 ] 

ASF subversion and git services commented on GEODE-9400:
--------------------------------------------------------

Commit 396f213bc64c6aba655cd064d6d96aeca2f44413 in geode's branch 
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=396f213 ]

GEODE-9400: Do not use Coder conversion methods in tests (#6643)

- Replace uses of Coder conversion methods in DUnit and Integration
 tests with implementations that do not assume knowledge of the way we
 internally handle such conversions.

Authored-by: Donal Evans <[email protected]>

> Do not use Coder methods in Redis tests
> ---------------------------------------
>
>                 Key: GEODE-9400
>                 URL: https://issues.apache.org/jira/browse/GEODE-9400
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Donal Evans
>            Assignee: Donal Evans
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> Following a recent refactor, the {{Coder.stringToBytes()}} and 
> {{Coder.bytesToString()}} methods are used throughout the Radish module. 
> However, in integration and dunit tests, which emulate how a client interacts 
> with a Radish server, it is not appropriate to use this internal class and 
> its methods. Uses of Coder methods in tests other than unit tests should be 
> restored to {{new String(byte[])}} and {{String.getBytes()}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to