[
https://issues.apache.org/jira/browse/GEODE-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378250#comment-17378250
]
ASF subversion and git services commented on GEODE-9404:
--------------------------------------------------------
Commit f0e328ba3eb4a1b2b47bdca5d565b79e88fecdca in geode's branch
refs/heads/develop from Eric Shu
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f0e328b ]
GEODE-9404: Do not log error message if sender is not configured. (#6659)
* This is normal case for serial wan configuration. Error message should not be
logged when executing transactions.
* Log error message only if some events in a tx configured to group transaction
but
others do not have sender configured.
* Should not wait for lastTransactionEvent in a tx if no sender configured or
sender
does not set must group transaction.
> Should not log "No information for senderId: " if the node processing the tx
> does not have sender configured
> ------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-9404
> URL: https://issues.apache.org/jira/browse/GEODE-9404
> Project: Geode
> Issue Type: Bug
> Components: transactions
> Affects Versions: 1.14.0
> Reporter: Eric Shu
> Assignee: Eric Shu
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> In serial wan setting, not all nodes have the sender configured. These error
> logging should not be logged. But currently it is logged for every tx
> operation if the the node does not have sender configured (which is a normal
> case for serail wan).
> The following stack shows where it was logged.
> org.apache.geode.internal.cache.TXLastEventInTransactionUtils.checkNoSendersGroupTransactionEvents(TXLastEventInTransactionUtils.java:81)
> at
> org.apache.geode.internal.cache.TXLastEventInTransactionUtils.getLastTransactionEvent(TXLastEventInTransactionUtils.java:45)
> at
> org.apache.geode.internal.cache.TXState.firePendingCallbacks(TXState.java:250)
> at org.apache.geode.internal.cache.TXState.commit(TXState.java:544)
> at
> org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:237)
> at
> org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:444)
> {code:java}
> private static boolean
> checkNoSendersGroupTransactionEvents(List<EntryEventImpl> callbacks,
> Cache cache) throws ServiceConfigurationError {
> for (String senderId : getSenderIdsForEvents(callbacks)) {
> GatewaySender sender = cache.getGatewaySender(senderId);
> if (sender == null) {
> logger.error("No sender found for {}", senderId, new Exception());
> throw new ServiceConfigurationError("No information for senderId: " +
> senderId);
> }
> if (sender.mustGroupTransactionEvents()) {
> return false;
> }
> }
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
