[
https://issues.apache.org/jira/browse/GEODE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401345#comment-17401345
]
ASF subversion and git services commented on GEODE-9511:
--------------------------------------------------------
Commit 2d459a60355906b3494c08ee805a22628125d109 in geode-native's branch
refs/heads/GEODE-9511-allow-default-sdk-for-ACE from Mike Martell
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=2d459a6 ]
GEODE-9511: Update ACE cmake config for VS2019
> Allow Default WindowsSDK in ACE cmake build
> -------------------------------------------
>
> Key: GEODE-9511
> URL: https://issues.apache.org/jira/browse/GEODE-9511
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Priority: Major
>
> The cmake configuration file for ACE currently uses the CMAKE_SYSTEM_VERSION
> variable to set the WindowsTargetPlatformVersion for ACE's build system
> (called MPC):
> set ( _CONFIGURE_COMMAND ${MPC} -static ${MPC_FLAGS}
> -name_modifier "*_${MPC_TYPE}_static"
> -value_template MultiProcessorCompilation=true
> -value_template WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION} set (
> _CONFIGURE_COMMAND ${MPC} -static ${MPC_FLAGS}
> -name_modifier "*_${MPC_TYPE}_static"
> -value_template MultiProcessorCompilation=true
> -value_template WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION}
>
> This requires the user to pass in a proper value for CMAKE_SYSTEM_VERSION on
> the cmake config line:
> cmake -DCMAKE_SYSTEM_VERSION=10.0.19041.0
> due to an apparent error in the default value of this variable which leaves
> off the last part (i.e., .0 above).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
