[ 
https://issues.apache.org/jira/browse/GEODE-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406924#comment-17406924
 ] 

ASF GitHub Bot commented on GEODE-9559:
---------------------------------------

mmartell commented on pull request #862:
URL: https://github.com/apache/geode-native/pull/862#issuecomment-908649949


   The procedure for this PR consisted of cutting/pasting the original macro 
invocations with the corresponding preprocessor output. Although there are 
quite a few files involved, the changes are basically all the same. For this 
reason it seemed prudent to submit this as a single PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Demacroize clicache 
> --------------------
>
>                 Key: GEODE-9559
>                 URL: https://issues.apache.org/jira/browse/GEODE-9559
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>              Labels: pull-request-available
>
> Macros in C++ complicate debug efforts and code maintenance and are generally 
> considered old school ([https://stroustrup.com/icsm-2012-demacro.pdf).] This 
> PR is to remove all the complicated macros in the .NET Framework client, e.g. 
> the clicache module.
> In addition to improving the maintainability of the clicache module, removing 
> the macros will greatly assist the creation of the .NET Core client. [dotPeek 
> |http://jetbrains.com/decompiler/] is proving to be a valuable tool in the 
> .NET Core project, but is currently limited by the extensive use of macros in 
> the clicache code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to