[
https://issues.apache.org/jira/browse/GEODE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430640#comment-17430640
]
ASF GitHub Bot commented on GEODE-9741:
---------------------------------------
mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732053680
##########
File path: ci/base/base.yml
##########
@@ -72,7 +72,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64
-DCMAKE_SYSTEM_VERSION=10.0.16299.0"
+ CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv142,version=14.29,host=x64
-DCMAKE_SYSTEM_VERSION=10.0.19041.0"
Review comment:
No. This is only for the Windows-2019 builds. The vs-2017 build (see
line 64 above) are not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline
> -------------------------------------------------------------
>
> Key: GEODE-9741
> URL: https://issues.apache.org/jira/browse/GEODE-9741
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Currently the VS 2019 builds use the old toolchain (v141). All tests pass
> with v142, so just requires a small change to CI code, as well as adding the
> v142 tools to the Windows images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
