[
https://issues.apache.org/jira/browse/GEODE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436827#comment-17436827
]
ASF GitHub Bot commented on GEODE-9741:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #888:
URL: https://github.com/apache/geode-native/pull/888#discussion_r740199943
##########
File path: ci/lib/templates.lib.txt
##########
@@ -203,6 +203,9 @@ git_rev=$(git rev-parse HEAD)
popd
version=$(cat version/number)
builddate=$(date "+%Y-%m-%d")
+(@- if use_vcvarsall: @)
+remote_shell "c:/Program Files (x86)\Microsoft Visual
Studio/2019/Community/VC/Auxiliary/Build/vcvarsall.bat" x64 10.0.16299.0
-vcvars_ver=14.20
Review comment:
How are these env changes surviving past this single invocation of the
command processor?
Needed my vcvars is a heavy hammer. A small fix to ACE CMake file should
pass all you need to ACE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline
> -------------------------------------------------------------
>
> Key: GEODE-9741
> URL: https://issues.apache.org/jira/browse/GEODE-9741
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Currently the VS 2019 builds use the old toolchain (v141). All tests pass
> with v142, so just requires a small change to CI code, as well as adding the
> v142 tools to the Windows images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
