[ https://issues.apache.org/jira/browse/GEODE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445561#comment-17445561 ]
ASF subversion and git services commented on GEODE-9449: -------------------------------------------------------- Commit e832de0fddc8b3b9b4d8d9a6ad24eba87373dc1e in geode's branch refs/heads/develop from Kris10 [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e832de0 ] GEODE-9449: Remove 'b' prefix from constants (#7118) Removed 'b' prefix on all byte arrays and added "_STRING" to string constants. Co-authored-by: Kristen Oduca <koduca@Administrators-MacBook-Pro.local> > remove 'b' prefix from constants > -------------------------------- > > Key: GEODE-9449 > URL: https://issues.apache.org/jira/browse/GEODE-9449 > Project: Geode > Issue Type: Improvement > Components: redis > Affects Versions: 1.15.0 > Reporter: Darrel Schneider > Assignee: Kristen > Priority: Minor > Labels: pull-request-available > > I number of constants in the redis packages have a 'b' prefix on their name. > This might have been a use of Hungarian notation but that is not clear. The > convention for constant names in geode is all upper case with underscore > between words. So the 'b' prefix should be removed. See StringBytesGlossary > for the location of many of these constants. Most of the constants in > StringBytesGlossary contains bytes, one or more, but if a few of the > constants in it are actually String instances. Consider renaming them to have > _STRING suffix or moving them to another class like StringGlossary. > The byte array constants in this class are marked with the MakeImmutable > annotation. -- This message was sent by Atlassian Jira (v8.20.1#820001)