[
https://issues.apache.org/jira/browse/GEODE-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480290#comment-17480290
]
ASF subversion and git services commented on GEODE-9885:
--------------------------------------------------------
Commit b8dd86b846083a59ffe1aa56b489df60f4d75d39 in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b8dd86b ]
GEODE-9885: Handle duplicated appends in Redis StringsDUnitTest (#7290)
* GEODE-9885: Handle duplicated appends in Redis StringsDUnitTest
- The Jedis client automatically retries when a bucket is moved during
an APPEND operation, which can lead to the append being duplicated. Add
error handling to the test to check if unexpected append values are
duplicates of the previous append and if so, ignore the AssertionError
- Add missing synchronization around in-place array modification in
RedisString.applyReplaceByteArrayAtOffsetDelta() method
- Remove unnecessarily overridden method from NullRedisSet
Authored-by: Donal Evans <[email protected]>
> StringsDUnitTest.givenBucketsMoveDuringAppend_thenDataIsNotLost fails with
> duplicated append
> --------------------------------------------------------------------------------------------
>
> Key: GEODE-9885
> URL: https://issues.apache.org/jira/browse/GEODE-9885
> Project: Geode
> Issue Type: Bug
> Components: redis
> Affects Versions: 1.15.0
> Reporter: Ray Ingles
> Assignee: Donal Evans
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> The test appends a lot of strings to a key. It wound up adding (at least one)
> extra string to the stored string:
> {\{java.util.concurrent.ExecutionException: java.lang.AssertionError:
> unexpected -{append0}-key-3-27680 at index 27681 iterationCount=61995 in
> string}}
> The string "\{append0}-key-3-27680" appeared twice in sequence.
> Additional to this failure, the test should be modified to produce a more
> useful failure message. The current assertion prints the entire String upon
> failure, which can contain upwards of 50,000 repeats of the
> "\{append0}-key-3*" String, making the output large and unreadable. Consider
> using an assertion with {{.withFailureMessage()}} to produce a more useful
> error message rather than the currently used {{Assert.fail().}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
