[ https://issues.apache.org/jira/browse/GEODE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480322#comment-17480322 ]
ASF subversion and git services commented on GEODE-9922: -------------------------------------------------------- Commit 7b0a88dbee36c6eb51513715af943f80ea6d93f9 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7b0a88d ] GEODE-9922: Move Redis cross-slot checking to RegionProvider (#7295) * GEODE-9922: Move Redis cross-slot checking to RegionProvider - Move duplicated logic for determining if Keys are in different slots from various Executors to RegionProvider - Removed manual checks for if the key is local, as this is performed as part of locking the primary bucket - Created RedisCrossSlotException class - Added unit tests for new method in RegionProvider - Refactor SetOpExecutor to also lock the destination key for *STORE commands - Add missing test cases for cross-slot errors - Correct some tests for cross-slot behaviour that were inadvertantly testing the Jedis client's response rather than the Geode for Redis server - Changed name format for constants in AbstractSMoveIntegrationTest - Modify patch file to ensure tcl tests use keys with the same slot Authored-by: Donal Evans <doev...@vmware.com> > Consistently check multi key arguments map to the same slot > ------------------------------------------------------------ > > Key: GEODE-9922 > URL: https://issues.apache.org/jira/browse/GEODE-9922 > Project: Geode > Issue Type: Improvement > Components: redis > Reporter: Jens Deppe > Assignee: Donal Evans > Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Multi-key commands should use a consistent approach to validate that all the > given keys are in the same slot. This could be done in > `RegionProvider.lockedExecute` since all commands eventually end up there. > As an aside, checking slot equivalence is not the same as ensuring that keys > are local to the server (which also still needs to happen). -- This message was sent by Atlassian Jira (v8.20.1#820001)