[
https://issues.apache.org/jira/browse/GEODE-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492798#comment-17492798
]
ASF subversion and git services commented on GEODE-10042:
---------------------------------------------------------
Commit 592dd652c263c2f043c6f6a11c5fd7f8a61c84a6 in geode's branch
refs/heads/develop from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=592dd65 ]
GEODE-10042: do not make ClientUserAuths null when we are not unregister client
yet. (#7357)
* make cleanUserAuths synchronized to avoid NPE
* This also pass down client termination reason when we clean up client threads.
* since we introduced a lock object for clientUserAuths, revert some old code
to not to catch NPE but use the lock
* synchronize all clientUserAuths updates.
> ServerConnection would make the ClientUserAuths null when there are still
> client using that connection
> ------------------------------------------------------------------------------------------------------
>
> Key: GEODE-10042
> URL: https://issues.apache.org/jira/browse/GEODE-10042
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Affects Versions: 1.14.3
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
> Priority: Major
> Labels: needsTriage, pull-request-available
>
> In `handleTermination` method, when we calculate there are still client
> threads using this connection, we should not cleanup clientUserAuth (this is
> done correctly), but we make the clientUserAuth null regardless, this would
> result in NPE sent down to the client.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
