[ 
https://issues.apache.org/jira/browse/GEODE-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-10358:
------------------------------
    Description: 
Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE.

PR #6225 is trying to redefine the {{nodes}} stat in DistributionStats. 
Understanding why this change is not allowed requires understanding the 
difference between LOCATOR_DM_TYPE and NORMAL_DM_TYPE.

Servers and Locators started via Gfsh are both of type NORMAL_DM_TYPE, however, 
some locators are of the type LOCATOR_DM_TYPE.

Older scripts and tools set:
{noformat}
System.setProperty(InternalLocator.FORCE_LOCATOR_DM_TYPE, "true");
{noformat}
which then results in the locator in that JVM having LOCATOR_DM_TYPE. Otherwise 
is of type NORMAL_DM_TYPE.

DistributionStats {{nodes}} is defined as NOT counting processes of type 
LOCATOR_DM_TYPE.

  was:
Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE.

PR #6225 is trying to redefine the nodes stat in DistributionStats and the 
author seems to be unfamiliar with the difference between LOCATOR_DM_TYPE and 
NORMAL_DM_TYPE.

Servers and Locators started via Gfsh are both of type NORMAL_DM_TYPE, however, 
some locators are of the type LOCATOR_DM_TYPE.

Older scripts and tools set:
{noformat}
System.setProperty(InternalLocator.FORCE_LOCATOR_DM_TYPE, "true");
{noformat}
which then results in the locator in that JVM having LOCATOR_DM_TYPE. Otherwise 
is of type NORMAL_DM_TYPE.

DistributionStats {{nodes}} is defined as NOT counting processes of type 
LOCATOR_DM_TYPE.


> Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE
> --------------------------------------------------------
>
>                 Key: GEODE-10358
>                 URL: https://issues.apache.org/jira/browse/GEODE-10358
>             Project: Geode
>          Issue Type: Wish
>          Components: membership, tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: pull-request-available
>
> Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE.
> PR #6225 is trying to redefine the {{nodes}} stat in DistributionStats. 
> Understanding why this change is not allowed requires understanding the 
> difference between LOCATOR_DM_TYPE and NORMAL_DM_TYPE.
> Servers and Locators started via Gfsh are both of type NORMAL_DM_TYPE, 
> however, some locators are of the type LOCATOR_DM_TYPE.
> Older scripts and tools set:
> {noformat}
> System.setProperty(InternalLocator.FORCE_LOCATOR_DM_TYPE, "true");
> {noformat}
> which then results in the locator in that JVM having LOCATOR_DM_TYPE. 
> Otherwise is of type NORMAL_DM_TYPE.
> DistributionStats {{nodes}} is defined as NOT counting processes of type 
> LOCATOR_DM_TYPE.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to