[ 
https://issues.apache.org/jira/browse/GEODE-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Bretl updated GEODE-42:
----------------------------
    Attachment: GEODE-42-2.patch

Updated patch...

Added IF conditional to check for '.git' folder in rootProject directory. If it 
finds the directory, it uses git commands, else it uses hardcoded values. I 
used 'UNKNOWN', feel free to add your own suggestion.

Tested with and without .git directory, I got expected result of commitId with 
.git and 'UNKNOWN' without .git directory

> Remove hard-coded SCM metadata from build
> -----------------------------------------
>
>                 Key: GEODE-42
>                 URL: https://issues.apache.org/jira/browse/GEODE-42
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.0.0-incubating
>            Reporter: Anthony Baker
>            Assignee: Mark Bretl
>            Priority: Minor
>         Attachments: GEODE-42-1.patch, GEODE-42-2.patch
>
>
> In gemfire-core/build.gradle the createVersionPropertiesFile task uses 
> hard-coded source information:
> {code}
>     ext.gitBranch = 'master'
>     ext.commitId = '1366ff2d4fcbf54bfad684e9ba9822db2a2b0ff5'
>     ext.sourceDate = '2015-04-06 14:54:51 -0700'
> {code}
> Previously this information was obtained from SCM (e.g. invoking the git 
> command directly).  However, we will be releasing src tarballs and need to 
> build from source without access to SCM metadata.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to