[ https://issues.apache.org/jira/browse/GEODE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949494#comment-14949494 ]
ASF GitHub Bot commented on GEODE-18: ------------------------------------- GitHub user robertgeiger opened a pull request: https://github.com/apache/incubator-geode/pull/20 GEODE-18 fixing existing header files Fix existing license header files and some minor constant string fixes for GEODE-18 Minor string constant changes in: ra.xml build.gradle gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java gemfire-core/src/main/java/com/gemstone/gemfire/cache/partition/PartitionListenerAdapter.java No code changes, only header changes. Reviewed large diff as diligently as possible to insure only header changes exist. Ran build; not all tests work on my laptop but nothing different in tests observed after changes. Remaining work is appx 900 files without any apparent header; these are hard to automate as some have existing license headers that must be preserved. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertgeiger/incubator-geode develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 ---- commit 5695e121e9a93ed55d46955d451feef2523f8e69 Author: Robert Geiger <rgeiger@ampoolrocket.local> Date: 2015-10-08T21:09:15Z GEODE-18 : replace old License headers with appropriate Apache License in files. (1) apply 0001-Replace-Pivotal-License-Header-with-Apache-License.patch, fixing any issues; (2) apply 0002-Add-Missing-Apache-License-headers.patch, fixing any issues; (3) automate (python) replacement of remaining easily identified headers, check; (4) hand fix any remaining files. Banner.java still needs appropriate text and one more sweep to detect any files without any header is needed. commit 1ab9b68b924f580fd367fc15d5acb6caa7ccfda9 Author: Robert Geiger <rgeiger@ampoolrocket.local> Date: 2015-10-08T21:41:23Z GEODE-18 : fix accidental mode changes on some files in previous checkin; no code change at all, file mode change only ---- > Initial Code Cleanup > -------------------- > > Key: GEODE-18 > URL: https://issues.apache.org/jira/browse/GEODE-18 > Project: Geode > Issue Type: Task > Components: general > Affects Versions: 1.0.0-incubating > Reporter: Niall Pemberton > Assignee: Dick Cavender > Fix For: 1.0.0-incubating > > Attachments: > 0001-Replace-Pivotal-License-Header-with-Apache-License.patch, > 0002-Add-Missing-Apache-License-headers.patch, > geode-rat-report-2015-05-11.txt, geode-rat-report-2015-05-17.txt > > > Please see the Incubator guide: > * http://incubator.apache.org/guides/mentor.html#initial-clean-up > Source & Notice File policy: > * http://www.apache.org/legal/src-headers.html > Apache RAT is a tool that can help with source file headers: > * http://creadur.apache.org/rat/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)