[
https://issues.apache.org/jira/browse/GEODE-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066809#comment-15066809
]
ASF subversion and git services commented on GEODE-680:
-------------------------------------------------------
Commit bb794ee205400ac4e5655cc1e6410889d29f28b1 in incubator-geode's branch
refs/heads/feature/GEODE-14 from [~sboorlagadda]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=bb794ee ]
GEODE-680: refactor Chunk to cleanup unit tests
1) Promoted constant fields to default access level.
2) Modified getAddressForReading to delegate to getUnsafeAddress.
> Chunk class refactoring encountered while writing unit tests.
> -------------------------------------------------------------
>
> Key: GEODE-680
> URL: https://issues.apache.org/jira/browse/GEODE-680
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Sai Boorlagadda
> Assignee: Sai Boorlagadda
>
> Good to have Chunk refactoring encountered while writing unit tests
> 1. Promote REF_COUNT_OFFSET to at-least protected access level and use it in
> GemFireChunkJUnitTest - search by REF_COUNT_OFFSET in the comments.
> 2. Promote MAX_REF_COUNT to at-least protected access level and use it in
> GemFireChunkJUnitTest.retainShouldThrowExceptionAfterMaxNumberOfTimesRetained
> 3. Promote IS_SERIALIZED_BIT & IS_COMPRESSED_BIT to at-least protected level
> and use it in GemFireChunkJUnitTest - search by IS_SERIALIZED_BIT in the
> comments
> 4. Chunk.getAddressForReading - can delete to Chunk.getUnsafeAddress, as both
> the methods are similar and `getUnsafeAddress` has more assert checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
