[
https://issues.apache.org/jira/browse/GEODE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123983#comment-15123983
]
ASF GitHub Bot commented on GEODE-874:
--------------------------------------
Github user pdxrunner commented on the pull request:
https://github.com/apache/incubator-geode/pull/82#issuecomment-176913037
You're correct. I should have changed "./gradlew" to just "gradle" for the
.txt and .md files I updated. I also agree that gradlew, not gradle, is the
correct usage in Dockerfile.
The problem here with using gradlew is that it's not part of the release
distributions. As part of the source distro we shouldn't be calling out a
script that's not part of the package. I realize that this conflicts with the
common usage when building from a clone of the github repo. Any suggestion for
handling this disconnect between building from source distro vs. repo clone? I
favor making the text instructions consistent with the release.
Should we go back to Anthony's suggestion in GEODE-826 to use the gradlew
script from bigtop which I understand could be included in the GEODE source
distro.
> v1.0.0-incubating.M1.RC2: Text file errors in the source distribution
> ---------------------------------------------------------------------
>
> Key: GEODE-874
> URL: https://issues.apache.org/jira/browse/GEODE-874
> Project: Geode
> Issue Type: Bug
> Components: docs
> Reporter: Kenneth Howe
> Assignee: Kenneth Howe
>
> gradlew script is not included in the Geode release packages, but it is
> called out in command examples in the following text files in the release
> source distribution:
> COMPILING.txt
> RUNNING.txt
> docker/Dockerfile
> gemfire-spark-connector/doc/1_building.md
> The easy fix is to change "gradlew" to "gradle" in affected files and include
> a requirement for the user to install gradle from gradle.org.
> There was a similar issue with README.md that was fixed for RC2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
