[
https://issues.apache.org/jira/browse/GEODE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287145#comment-15287145
]
ASF GitHub Bot commented on GEODE-1296:
---------------------------------------
GitHub user pdxrunner opened a pull request:
https://github.com/apache/incubator-geode/pull/145
GEODE-1296: change conditional in getRawBytes to assert
Made suggested change to getRawBytes. Updated corresponding unit test.
See review request https://reviews.apache.org/r/47479/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1296
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit 538e0483d3e6fa7e04f5834be27d5540fbda792f
Author: Ken Howe <kh...@pivotal.io>
Date: 2016-05-12T22:04:16Z
GEODE-1296: change conditional in getRawBytes to assert
Updated correspondiong unit test.
----
> OffHeapStoredObject.getRawBytes should assert that it is not called on
> compressed data
> --------------------------------------------------------------------------------------
>
> Key: GEODE-1296
> URL: https://issues.apache.org/jira/browse/GEODE-1296
> Project: Geode
> Issue Type: Bug
> Components: offheap
> Reporter: Darrel Schneider
> Assignee: Kenneth Howe
>
> The current code does this:
> if (isCompressed()) {
> throw new UnsupportedOperationException();
> }
> It would be more clear if it just did this:
> assert !isCompressed();
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
