[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404573#comment-15404573
 ] 

ASF GitHub Bot commented on GEODE-1648:
---------------------------------------

Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/224#discussion_r73212878
  
    --- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
    @@ -447,8 +449,7 @@ public synchronized void start() throws IOException {
           }
         };
     
    -    String shiroConfig = this.config.getShiroInit();
    -    if (! StringUtils.isBlank(shiroConfig) || isIntegratedSecurity()) {
    +    if (isIntegratedSecurity()) {
    --- End diff --
    
    probably be easier to read if it just read "if 
(GeodeSecurityUtil.isJmxSecurityEnabled())" here.


> Provide ability to disable security for some components
> -------------------------------------------------------
>
>                 Key: GEODE-1648
>                 URL: https://issues.apache.org/jira/browse/GEODE-1648
>             Project: Geode
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to