[
https://issues.apache.org/jira/browse/GEODE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556376#comment-15556376
]
ASF subversion and git services commented on GEODE-1926:
--------------------------------------------------------
Commit 654b06ed2fc1d740fe6c2cb2b40fd92b17d5a8dc in incubator-geode's branch
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=654b06e ]
GEODE-1926: Modification of peedAhead() function
* Modification of peedAhead() function check if heapCopy is successful
before adding the key to peekedIds.
* Since peek() doesnt have access to the current key but just the
object and hence cannot remove it from peekedIDs list, we moved the check for
heapcopy into peekAhead.
* So now only if a successful heap copy is made then only the key will
be placed into the peekedIDs list.
> The function peekAhead function puts the queue key into peekedIDs even though
> it was not in the batch to be dispatched
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-1926
> URL: https://issues.apache.org/jira/browse/GEODE-1926
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: nabarun
>
> The function peekAhead peeks the serial sender queue and if its able to get
> an object in the queue, returns the object to the peek function to be
> dispatched and adds the key to the peekedIds list.
> The peek function tries to make a heap copy of the object returned , but
> conflation may have kicked in the object may have been removed - hence the
> object will not be placed in the dispatch batch.
> However now the size of the peeked Ids and dispatched batch do not match,
> hence when the remove thread starts removing the elements from the key using
> the keys in peekedIds and using the size of the dispatched batch, there will
> be lingering objects in the queue because the size of dispatched batch is
> less than Ids that were peeked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
