[ 
https://issues.apache.org/jira/browse/GUACAMOLE-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891220#comment-16891220
 ] 

Michael Jumper edited comment on GUACAMOLE-854 at 7/23/19 5:16 PM:
-------------------------------------------------------------------

I would say:

# Yes to {{TRACE}} level, and that should probably be part of GUACAMOLE-422.
# We should add an empty handler for {{nop}}, as it's a legit instruction 
(probably makes sense to be part of GUACAMOLE-422 there, too).
# Those empty opcodes are handled by the Java side of the tunnel 
implementation. There's something strange about this deployment if they are 
being received by guacd. They are explicitly filtered: 
https://github.com/apache/guacamole-client/blob/0484a4e485904625d924b796145ff341523677cd/guacamole-common/src/main/java/org/apache/guacamole/websocket/GuacamoleWebSocketTunnelEndpoint.java#L313-L334


was (Author: mike.jumper):
I would say:

# Yes to {{TRACE}} level, and that should probably be part of GUACAMOLE-422.
# We should add an empty handler for {{nop}}, as it's a legit instruction.
# Those empty opcodes are handled by the Java side of the tunnel 
implementation. There's something strange about this deployment if they are 
being received by guacd. They are explicitly filtered: 
https://github.com/apache/guacamole-client/blob/0484a4e485904625d924b796145ff341523677cd/guacamole-common/src/main/java/org/apache/guacamole/websocket/GuacamoleWebSocketTunnelEndpoint.java#L313-L334

> Debug level guacd logs spammed with "Handler not found for"
> -----------------------------------------------------------
>
>                 Key: GUACAMOLE-854
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-854
>             Project: Guacamole
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>         Environment: guacd: staging/1.1.0
> guacamole-common-js: staging/1.1.0
>            Reporter: Richard Lancaster
>            Priority: Minor
>
> When running guacd with DEBUG level logs, the logs are spammed with: 
> {noformat}
> guacd[9]: DEBUG: Handler not found for "nop"
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for "nop"
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> guacd[9]: DEBUG: Handler not found for ""
> {noformat}
> I think the empty strings are caused by these instructions: 
> `0.,4.ping,13.1563882935963`.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to