[
https://issues.apache.org/jira/browse/GUACAMOLE-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Jumper reassigned GUACAMOLE-930:
-------------------------------------
Assignee: Mike Jumper
> "Display language" menu is empty in Guacamole preferences
> ---------------------------------------------------------
>
> Key: GUACAMOLE-930
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-930
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Affects Versions: 1.1.0
> Reporter: Mike Jumper
> Assignee: Mike Jumper
> Priority: Major
> Fix For: 1.1.0
>
>
> As noted in [guacamole-client pull request
> #453|https://github.com/apache/guacamole-client/pull/453] for GUACAMOLE-903,
> the current {{staging/1.1.0}} branch fails to render the "Display language"
> menu in the Guacamole preferences page, instead presenting an empty menu.
> This behavior appears to be a regression introduced by GUACAMOLE-630 and was
> not present in 1.0.0.
> The failure is due to an {{[$rootScope:inprog]}} error on the
> {{$scope.$apply()}} call within {{languageFieldController}} which assigns the
> available languages:
> {code:javascript}
> // Retrieve defined languages
> languageService.getLanguages().then(function languagesRetrieved(languages) {
> $scope.$apply(function updateLanguageOptions() {
> $scope.languages = languages;
> });
> }, requestService.DIE);
> {code}
> According to git bisect, the specific commit introducing the issue is [commit
> 93ba19a|https://github.com/apache/guacamole-client/commit/93ba19ac26a3509878023886eee0140bcf3face9]:
> {code:none}
> commit 93ba19ac26a3509878023886eee0140bcf3face9
> Author: Michael Jumper <mjum...@apache.org>
> Date: Sun Aug 18 22:00:16 2019 -0700
> GUACAMOLE-630: Create a new injector for field type instances only if
> needed.
>
> Creating a new injector re-initializes services and providers within
> its modules. If those services or providers rely on being singletons
> (as colorPickerService does), this produces unexpected behavior.
> :040000 040000 d915e8e91b46dfae89c126515aca83a215e0becf
> 884ef37f363f2e180f94b4fd48f13782cc77657d M guacamole
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
