[
https://issues.apache.org/jira/browse/GUACAMOLE-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Jumper updated GUACAMOLE-1276:
-----------------------------------
Description:
>From GUACAMOLE-764:
{quote}
While file sizes are now properly-represented with 64-bit integers (see
GUACAMOLE-268), the offset of each read/write is still a simple {{int}}. This
will limit the location of each read or write to a 32-bit addressable space,
thus effectively limiting the size of files transferred to 4 GB: ...
{quote}
This was correctly addressed with [guacamole-server PR
#223|https://github.com/apache/guacamole-server/pull/223/files#diff-f5fd7fdc2c1331b32ab1899613971f13dd00be3e048e3dcdaeddc584e3d91b23R60],
but those changes were inadvertently undone during conflict resolution of
GUACAMOLE-249, and that offset is back to being an {{int}}:
https://github.com/mike-jumper/guacamole-server/blob/53f981f864475763f64d608ca1dfea7c7e094472/src/protocols/rdp/upload.h#L36-L40
was:
This problem exists regardless of whether it is installed natively or deployed
using Docker.
I seem to have seen the same problem before, but I can’t find it now.
*Problem Description:*
Upload any file larger than 4GB, and after reaching the 4GB file in guacamole
shared disk inside the file transfer can not continue
> RDP file uploads may (still) be truncated to 32 bits
> ----------------------------------------------------
>
> Key: GUACAMOLE-1276
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1276
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
> Affects Versions: 1.2.0, 1.3.0
> Reporter: wuxiaobai
> Priority: Major
>
> From GUACAMOLE-764:
> {quote}
> While file sizes are now properly-represented with 64-bit integers (see
> GUACAMOLE-268), the offset of each read/write is still a simple {{int}}. This
> will limit the location of each read or write to a 32-bit addressable space,
> thus effectively limiting the size of files transferred to 4 GB: ...
> {quote}
> This was correctly addressed with [guacamole-server PR
> #223|https://github.com/apache/guacamole-server/pull/223/files#diff-f5fd7fdc2c1331b32ab1899613971f13dd00be3e048e3dcdaeddc584e3d91b23R60],
> but those changes were inadvertently undone during conflict resolution of
> GUACAMOLE-249, and that offset is back to being an {{int}}:
> https://github.com/mike-jumper/guacamole-server/blob/53f981f864475763f64d608ca1dfea7c7e094472/src/protocols/rdp/upload.h#L36-L40
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
