[ https://issues.apache.org/jira/browse/GUACAMOLE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Couchman closed GUACAMOLE-1630. ------------------------------------ Resolution: Incomplete Without further information on what is being proposed, and given that the reporter has not responded, I'm closing this out. > Potential Refactoring Estimate > ------------------------------ > > Key: GUACAMOLE-1630 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1630 > Project: Guacamole > Issue Type: Improvement > Reporter: Alvin Tan Jian Jia > Priority: Minor > Attachments: Guacamole-client_1.4.0.csv > > > **Summary** > I have identified a few classes with refactoring potential along with its > estimated time to refactor, specifically > ActiveConnectionPermissionService.java. The estimated time is based on > historical commits containing refactoring and the complexity of the involved > classes. The class was refactored once on Sep 20, 2018 along with other > classes in commit 69f58c8ca314c44822e0eaab354b5f722a01ac89. Given the > duration of the last refactoring, could it be possible to improve this class > further? I am probably not qualified and experienced enough to point out the > exact code needs to be refactored, given my limited knowledge of the project > and codebase. > > **Urgency** > Low priority. For maintenance of code in the long run. > > Hi, > I am currently doing some research on Estimating Time Taken for Software > Refactoring. Guacamole is one of my case studies being a highly popular > project. Would appreciate your kind feedback on the appropriateness of the > estimated time to refactor. > I am specifically looking at potential for refactoring, such as breaking > functions that are too long into shorter functions, or to remove code > duplication. Would you agree that there could be some modification to the > code to make it better in the listed classes? And if so, is the estimated > time appropriate to carry out the improvement? I will be grateful for any > help you can provide. > # ActiveConnectionPermissionService.java - 2 hours > # EntityMapper.java - 2 hours > # EntityService.java - 3 hours > Thank you. > Regards, > Alvin -- This message was sent by Atlassian Jira (v8.20.10#820010)