[
https://issues.apache.org/jira/browse/GUACAMOLE-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Jumper updated GUACAMOLE-1772:
-----------------------------------
Description:
{panel}
*NOTE:* Some commits erroneously tag this issue in the git commit history
instead of "GUACAMOLE-1722". If looking for the JIRA issue related to a commit,
but that commit doesn't seem related to this, check GUACAMOLE-1722.
{panel}
Adding `@Nullable` and `@NotNull` annotations in the Java codebase would be
really nice - this would not only make it easier to understand the code, but it
would even have prevented issues like the one described in GUACAMOLE-1769, as
the compiler would have caught the potential NPE.
It'd be a big project to add these to the entire codebase at the same time, so
maybe it might make sense to break this up into smaller pieces, though adding
these annotations often results in a cascading refactor where more and more
things need to be annotated.
was:
Adding `@Nullable` and `@NotNull` annotations in the Java codebase would be
really nice - this would not only make it easier to understand the code, but it
would even have prevented issues like the one described in GUACAMOLE-1769, as
the compiler would have caught the potential NPE.
It'd be a big project to add these to the entire codebase at the same time, so
maybe it might make sense to break this up into smaller pieces, though adding
these annotations often results in a cascading refactor where more and more
things need to be annotated.
> Add @NotNull and @Nullable annotations everywhere in guacamole-client Java
> codebase
> -----------------------------------------------------------------------------------
>
> Key: GUACAMOLE-1772
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1772
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole-client
> Reporter: James Muehlner
> Priority: Minor
>
> {panel}
> *NOTE:* Some commits erroneously tag this issue in the git commit history
> instead of "GUACAMOLE-1722". If looking for the JIRA issue related to a
> commit, but that commit doesn't seem related to this, check GUACAMOLE-1722.
> {panel}
> Adding `@Nullable` and `@NotNull` annotations in the Java codebase would be
> really nice - this would not only make it easier to understand the code, but
> it would even have prevented issues like the one described in GUACAMOLE-1769,
> as the compiler would have caught the potential NPE.
> It'd be a big project to add these to the entire codebase at the same time,
> so maybe it might make sense to break this up into smaller pieces, though
> adding these annotations often results in a cascading refactor where more and
> more things need to be annotated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
