Ciro Iriarte created GUACAMOLE-2302:
---------------------------------------
Summary: Add test coverage for TokenFilter parameter token grammar
Key: GUACAMOLE-2302
URL: https://issues.apache.org/jira/browse/GUACAMOLE-2302
Project: Guacamole
Issue Type: Test
Reporter: Ciro Iriarte
guacamole-ext has TokenFilterTest covering basic substitution, escaping, and
the LOWER/UPPER modifiers, but no coverage pinning the boundaries of the token
grammar itself: which candidate token names the pattern accepts, how
unrecognized modifiers are handled, and how strict mode treats text that
resembles a token but is not one.
That behavior is currently load-bearing. filterStrict() has a single caller,
VaultUserContext.getTokens(), which resolves secret names from
vault-token-mapping.yml and treats GuacamoleTokenUndefinedException as a signal
to skip the secret. A change in which strings the pattern matches therefore
changes whether vault secrets are retrieved, silently.
Add characterization tests for the existing grammar so that any future change
to the token pattern is evaluated against current behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
