Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1353#discussion_r213480610
--- Diff:
pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/writercallable/WriterCallableFactory.java
---
@@ -0,0 +1,108 @@
+package org.apache.hawq.pxf.plugins.jdbc.writercallable;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hawq.pxf.api.OneRow;
+import org.apache.hawq.pxf.plugins.jdbc.JdbcPlugin;
+
+import java.sql.PreparedStatement;
+
+/**
+ * An object that processes INSERT operation on {@link OneRow} objects
+ */
+public class WriterCallableFactory {
+ /**
+ * Create a new factory.
+ *
+ * Note that before constructing {@link WriterCallable},
'setBatchSize' and 'setStatement' must be called.
+ *
+ * By default, 'batchSize' is 1 and 'statement' is null
+ */
+ public WriterCallableFactory() {
+ batchSize = 1;
+ plugin = null;
+ query = null;
+ statement = null;
+ }
+
+ /**
+ * Get an instance of WriterCallable
+ *
+ * @return an implementation of WriterCallable, chosen based on
parameters that were set for this factory
+ * @throws IllegalArgumentException if a WriterCallable cannot be
created with requested parameters
+ */
+ public WriterCallable get() throws IllegalArgumentException {
--- End diff --
do we need to explicitly declare throwing of runtime exceptions, such as
IllegalArgumentException ? It's not like the caller can recover from them in
these use cases.
---
