[
https://issues.apache.org/jira/browse/HAWQ-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962890#comment-14962890
]
Amy commented on HAWQ-67:
-------------------------
looks good to me. +1
> Wrong variable type for saving fgetc() return value
> ---------------------------------------------------
>
> Key: HAWQ-67
> URL: https://issues.apache.org/jira/browse/HAWQ-67
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Resource Manager
> Reporter: Yi Jin
> Assignee: Yi Jin
>
> line 3624. Truncated stdio return value (CHAR_IO)char_io: Assigning the
> return value of fgetc to char c truncates its value.
> 3621 initializeSelfMaintainBuffer(&smb, PCONTEXT);
> 3622 while( true )
> 3623 {
> 3624 char c = fgetc(fp);
> 3625 if ( c == EOF )
> 3626 {
> 3627 if ( feof(fp) == 0 )
> 3628 {
> 3629 elog(WARNING, "Failed to read slaves
> file, ferror() gets %d",
> 3630 ferror(fp));
> 3631 haserror = true;
> 3632 }
> 3633
> 3634 break;
> 3635 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
