[ 
https://issues.apache.org/jira/browse/HAWQ-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101231#comment-15101231
 ] 

ASF GitHub Bot commented on HAWQ-289:
-------------------------------------

Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/270#discussion_r49822843
  
    --- Diff: tools/bin/hawqpylib/hawqarray.py ---
    @@ -514,15 +514,14 @@ def initFromCatalog(dbURL, utility=False, 
useAllSegmentFileSpaces=False):
                                           sc.hostname,
                                           sc.address,
                                           sc.port,
    -                                      fs.oid,
    +
                                           CASE
                                               WHEN sc.registration_order <= 0 
THEN '%s'
                                               ELSE '%s'
                                           END AS datadir
    -                               FROM pg_catalog.gp_segment_configuration sc,
    -                                    pg_catalog.pg_filespace fs,
    -                                    pg_catalog.pg_filespace_entry fse
    -                               WHERE fse.fsefsoid = fs.oid
    +                               FROM pg_catalog.gp_segment_configuration sc
    +
    --- End diff --
    
    The blank lines here need to be removed.


> Support hawqfaultinjector as an internal utility for fault injection purpose 
> - server side
> ------------------------------------------------------------------------------------------
>
>                 Key: HAWQ-289
>                 URL: https://issues.apache.org/jira/browse/HAWQ-289
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: Command Line Tools
>    Affects Versions: 2.0.0-beta-incubating
>            Reporter: Ruilong Huo
>            Assignee: Ruilong Huo
>
> Due to the new architecture and new features such as recovery (filerep), FTS, 
> catalog, filespace/file organization, etc. We need to implement 
> hawqfaultinjector which is a replacement of gpfaultinjector as an internal 
> utility for fault injector purpose.
> This issue tracks the work for C server part for hawqfaultinjector.
> The remaining work includes: 1) Python wrapper, C client part for 
> hawqfaultinjector; 2) add/modify/remove fault type and name based on current 
> HAWQ code base. This will be tracked be by other issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to