[
https://issues.apache.org/jira/browse/HAWQ-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122657#comment-15122657
]
ASF GitHub Bot commented on HAWQ-178:
-------------------------------------
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51212800
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonAccessor.java
---
@@ -0,0 +1,66 @@
+package org.apache.hawq.pxf.plugins.json;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hawq.pxf.api.utilities.InputData;
+import org.apache.hawq.pxf.plugins.hdfs.HdfsSplittableDataAccessor;
+
+/**
+ * This JSON accessor for PXF will read JSON data and pass it to a {@link
JsonResolver}.
+ *
+ * This accessor supports a single JSON record per line, or a more "pretty
print" format.
+ */
+public class JsonAccessor extends HdfsSplittableDataAccessor {
+
+ public static final String IDENTIFIER_PARAM = "IDENTIFIER";
+ public static final String ONERECORDPERLINE_PARAM = "ONERECORDPERLINE";
+
+ private String identifier = "";
+ private boolean oneRecordPerLine = true;
+
+ public JsonAccessor(InputData inputData) throws Exception {
+ super(inputData, new JsonInputFormat());
+
+ if
(!StringUtils.isEmpty(inputData.getUserProperty(IDENTIFIER_PARAM))) {
+ identifier =
inputData.getUserProperty(IDENTIFIER_PARAM);
+ }
+
+ if
(!StringUtils.isEmpty(inputData.getUserProperty(ONERECORDPERLINE_PARAM))) {
+ oneRecordPerLine =
Boolean.parseBoolean(inputData.getUserProperty(ONERECORDPERLINE_PARAM));
+ }
+ }
+
+ @Override
+ protected Object getReader(JobConf conf, InputSplit split) throws
IOException {
+ conf.set(JsonInputFormat.RECORD_IDENTIFIER, identifier);
--- End diff --
same comment - if identifier is "", should we set it here or not?
> Add JSON plugin support in code base
> ------------------------------------
>
> Key: HAWQ-178
> URL: https://issues.apache.org/jira/browse/HAWQ-178
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Fix For: backlog
>
> Attachments: PXFJSONPluginforHAWQ2.0andPXF3.0.0.pdf
>
>
> JSON has been a popular format used in HDFS as well as in the community,
> there has been a few JSON PXF plugins developed by the community and we'd
> like to see it being incorporated into the code base as an optional package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
