[
https://issues.apache.org/jira/browse/HAWQ-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129266#comment-15129266
]
ASF GitHub Bot commented on HAWQ-369:
-------------------------------------
Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51651184
--- Diff: src/test/regress/output/hcatalog_lookup.source ---
@@ -266,6 +266,29 @@ select pg_catalog.pg_database_size('hcatalog');
ERROR: database hcatalog (OID 6120) is reserved (SOMEFILE:SOMEFUNC)
select pg_catalog.pg_database_size(6120);
ERROR: database hcatalog (OID 6120) is reserved (SOMEFILE:SOMEFUNC)
+--positive test: should be able to create table named "hcatalog"
+CREATE TABLE hcatalog(a int);
+--negative test: cannot create database named "hcatalog"
+CREATE DATABASE hcatalog;
+ERROR: "hcatalog" is a reserved name for hcatalog feature integration
+--allow renaming schemas and databases
--- End diff --
comment is misleading, should be "allow renaming schemas but not databases".
> Hcatalog as reserved name
> -------------------------
>
> Key: HAWQ-369
> URL: https://issues.apache.org/jira/browse/HAWQ-369
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Goden Yao
> Assignee: Goden Yao
> Labels: Hcatalog
>
> https://github.com/apache/incubator-hawq/tree/master/src/test/regress
> With Hcatalog integration, we've reserved "hcatalog" as keyword for the
> following scenarios
> *Acceptance Criteria*
> 1. {code}CREATE DATABASE hcatalog{code} should fail with a reserved name error
> {code}
> "hcatalog" is a reserved name for hcatalog feature integration
> {code}
> 2. {code}CREATE SCHEMA hcatalog{code} should be fine.
> 3. {code}CREATE TABLE hcatalog(hcatalog int){code} should be fine, there is
> no ambiguity for table/column names.
> 4. {code}ALTER DATABASE name RENAME to hcatalog{code} should fail with a
> reserved name error
> {code}"hcatalog" is a reserved name for hcatalog feature integration{code}
> 5. {code}ALTER DATABASE hcatalog RENAME to xxx{code} should fail with a
> system error
> {code}permission denied to ALTER DATABASE hcatalog is reserved for system
> use{code}
> 6. {code}\connect hcatalog{code} should fail with a system error
> {code}hcatalog database is only for system use{code}
> 7. Add regression tests to the above scenarios
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
