[ 
https://issues.apache.org/jira/browse/HAWQ-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172233#comment-15172233
 ] 

ASF GitHub Bot commented on HAWQ-455:
-------------------------------------

Github user xinzweb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/387#discussion_r54448638
  
    --- Diff: src/backend/commands/tablecmds.c ---
    @@ -13758,6 +13758,24 @@ ATPExecPartAdd(AlteredTableInfo *tab,
                                         errhint("use a named partition"),
                                                           
errOmitLocation(true)));
     
    +   PartitionElem *pElem = (PartitionElem *) pc2->arg1;
    +   Node *pStoreAttr = pElem->storeAttr;
    +   if (pStoreAttr && ((AlterPartitionCmd *)pStoreAttr)->arg1)
    +   {
    +           List *pWithList = (List *)(((AlterPartitionCmd 
*)pStoreAttr)->arg1);
    +           GpPolicy *parentPolicy = GpPolicyFetch(CurrentMemoryContext, 
RelationGetRelid(rel));
    +           int bucketnum = parentPolicy->bucketnum;
    --- End diff --
    
    Maybe rename to `parent_bucketnum`?


> Disable creating partition tables with non uniform bucket schema 
> -----------------------------------------------------------------
>
>                 Key: HAWQ-455
>                 URL: https://issues.apache.org/jira/browse/HAWQ-455
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: DDL
>            Reporter: Haisheng Yuan
>            Assignee: Lei Chang
>
> HAWQ user should not be able to create partition tables with non uniform 
> bucket schema so that don't make orca trip up when it queries across a single 
> partition. Or else the user should see an error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to