Hi Tom, Thank you for the pull request, and welcome to the contributor community!
Others can take a closer look, but looks good to me. +1 C.J. On Mon, Mar 14, 2016 at 9:40 AM, ASF GitHub Bot (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/HAWQ-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193600#comment-15193600 > ] > > ASF GitHub Bot commented on HAWQ-536: > ------------------------------------- > > GitHub user tom-meyer opened a pull request: > > https://github.com/apache/incubator-hawq/pull/448 > > HAWQ-536. Fix expected function.out when orca is not enabled > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/tom-meyer/incubator-hawq HAWQ-536 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/incubator-hawq/pull/448.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #448 > > ---- > commit 8992554400ccbffb857bc0fcde770ba827f711fb > Author: Devadass Santhosh Sampath and Tom Meyer <tme...@pivotal.io> > Date: 2016-03-12T02:03:07Z > > HAWQ-536. Fix expected function.out when orca is not enabled > > ---- > > > > Regress test 'function' fails when orca is not enabled > > ------------------------------------------------------ > > > > Key: HAWQ-536 > > URL: https://issues.apache.org/jira/browse/HAWQ-536 > > Project: Apache HAWQ > > Issue Type: Bug > > Components: Tests > > Reporter: Tom Meyer > > Assignee: Jiali Yao > > > > {noformat} > > The differences that caused some tests to fail can be viewed in the > > file "./regression.diffs". A copy of the test summary that you see > > above is saved in the file "./regression.out". > > make[2]: *** [installcheck-good] Error 1 > > make[2]: Leaving directory > `/tmp/build/486517ee/hawq_src/apache-hawq/src/test/regress' > > make[1]: *** [installcheck-good] Error 2 > > make[1]: Leaving directory > `/tmp/build/486517ee/hawq_src/apache-hawq/src/test' > > make: *** [installcheck-good] Error 2 > > *** ./expected/function.out 2016-03-11 03:53:32.533109484 +0000 > > --- ./results/function.out 2016-03-11 03:53:32.609109484 +0000 > > *************** > > *** 881,887 **** > > DROP FUNCTION inner(int); > > -- TEARDOWN > > DROP TABLE foo; > > - > > -- HAWQ-510 > > drop table if exists testEntryDB; > > create table testEntryDB(key int, value int) distributed randomly; > > --- 881,886 ---- > > *************** > > *** 894,896 **** > > --- 893,898 ---- > > -----+------- > > 1 | 0 > > 2 | 0 > > + (2 rows) > > + > > + drop table testEntryDB; > > {noformat} > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
