[
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196220#comment-15196220
]
ASF GitHub Bot commented on HAWQ-544:
-------------------------------------
GitHub user gcaragea opened a pull request:
https://github.com/apache/incubator-hawq/pull/454
HAWQ-544. Fixed assertion failure in AdvanceMemoryAccountingGeneration
Fixed assertion failure in AdvanceMemoryAccountingGeneration when we have a
generation overflow
In function AdvanceMemoryAccountingGeneration, we first assign
"RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak,
MemoryAccountingPeakBalance);", then we call elog if there is a generation
overflow. Then we assert "Assert(RolloverMemoryAccount->peak >=
MemoryAccountingPeakBalance);".
If elog allocates additional memory, then this causes the assertion to fail.
Signed-off-by: George Caragea <caragea.w...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gcaragea/incubator-hawq
gcaragea-accounting-assert
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #454
----
commit 4bdd246a01584ab9a916036153b3e64e99cd153a
Author: Foyzur Rahman <foy...@gmail.com>
Date: 2016-03-15T19:19:44Z
HAWQ-544. Fixed assertion failure in AdvanceMemoryAccountingGeneration when
we have a generation overflow
Signed-off-by: George Caragea <caragea.w...@gmail.com>
----
> Wrong MemoryAccountingPeakBalance assert after calling elog in function
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Query Execution
> Reporter: George Caragea
> Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak,
> MemoryAccountingPeakBalance);", then we call elog if there is a generation
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >=
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
