[ https://issues.apache.org/jira/browse/HAWQ-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230217#comment-15230217 ]
ASF GitHub Bot commented on HAWQ-635: ------------------------------------- Github user xunzhang commented on the pull request: https://github.com/apache/incubator-hawq/pull/564#issuecomment-206896207 @wangzw this fix seems right. But in my sight, I think we should limit the usage of `try ... catch` for the consideration of performance. Specially, catch small lines of codes is better. Another advice is that we should try to use `try catch` clause in library code in a flat scope as possible as we could. > QE process does not exit in libhdfs > ----------------------------------- > > Key: HAWQ-635 > URL: https://issues.apache.org/jira/browse/HAWQ-635 > Project: Apache HAWQ > Issue Type: Bug > Reporter: Ming LI > Assignee: Ming LI > > The QE process cannot exit. > The calling stack is: > [gpadmin@sdw3 ~]$ pstack 489333 > #0 0x00000033f560ef3d in nanosleep () from /lib64/libpthread.so.0 > #1 0x00007ff75309c74a in boost::this_thread::hiden::sleep_for(timespec > const&) () from > /data/pulse-agent-data/HAWQ-main-FeatureTest-opt-sanity/product/hawq/./lib/libboost_thread.so.1.53.0 > #2 0x00007ff755b850b8 in Hdfs::Internal::RpcChannelImpl::waitForExit() () > from > /data/pulse-agent-data/HAWQ-main-FeatureTest-opt-sanity/product/hawq/./lib/libhdfs3.so.1 > #3 0x00007ff755b97eff in Hdfs::Internal::RpcClientImpl::close() () from > /data/pulse-agent-data/HAWQ-main-FeatureTest-opt-sanity/product/hawq/./lib/libhdfs3.so.1 > #4 0x00007ff755b98094 in Hdfs::Internal::RpcClientImpl::~RpcClientImpl() () > from > /data/pulse-agent-data/HAWQ-main-FeatureTest-opt-sanity/product/hawq/./lib/libhdfs3.so.1 > #5 0x0000000000540c59 in boost::detail::shared_count::~shared_count() () > #6 0x00000033f52361bd in __cxa_finalize () from /lib64/libc.so.6 > #7 0x00007ff755b04456 in __do_global_dtors_aux () from > /data/pulse-agent-data/HAWQ-main-FeatureTest-opt-sanity/product/hawq/./lib/libhdfs3.so.1 > #8 0x0000000000000000 in ?? () -- This message was sent by Atlassian JIRA (v6.3.4#6332)