[
https://issues.apache.org/jira/browse/HAWQ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238513#comment-15238513
]
ASF GitHub Bot commented on HAWQ-666:
-------------------------------------
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/600#issuecomment-209208587
+1
> Restore to correct memory context after free query resource in ExecutorEnd
> --------------------------------------------------------------------------
>
> Key: HAWQ-666
> URL: https://issues.apache.org/jira/browse/HAWQ-666
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-beta-incubating
> Reporter: Ruilong Huo
> Assignee: Ruilong Huo
> Fix For: 2.0.0
>
>
> In ExecutorEnd, we need to restore to correct memory context after free query
> resource. There are two memory context based on PG_TRY of mppExecutorFinishup:
> 1. If mppExecutorFinishup completes successfully, the correct memory context
> is estate->es_query_cxt
> 2. If mppExecutorFinishup errors, the correct memory context is ErrorContext
> Current implementation use estate->es_query_cxt for both situation. We need
> to fix this as it may lead to core dump during memory context cleanup
> afterwards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
