[ 
https://issues.apache.org/jira/browse/HAWQ-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247212#comment-15247212
 ] 

ASF GitHub Bot commented on HAWQ-668:
-------------------------------------

Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/622#discussion_r60174348
  
    --- Diff: tools/bin/gpcheck ---
    @@ -567,7 +683,7 @@ def testHAWQ(host):
                 return
     
             # check HAWQ master's memory size
    -        expected_vmemory_size = 1024
    +        expected_vmemory_size = 8192
    --- End diff --
    
    do we want to check exact value, or minimal value ? in other words, should 
it be guc_vmemsize_master < expected_vmemory_size rather than 
guc_vmemsize_master != expected_vmemory_size in the statement below and other 
similar comparisons ?


> hawq check should able to check yarn settings
> ---------------------------------------------
>
>                 Key: HAWQ-668
>                 URL: https://issues.apache.org/jira/browse/HAWQ-668
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: Command Line Tools
>            Reporter: Radar Lei
>            Assignee: Radar Lei
>
> Since hawq now use yarn for resource manager, so we'd better to use 'hawq 
> check' to validate yarn configurations.
> BTW, we should update some os, hdfs, hawq-site.xml expected values with 
> latest best practice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to